search

staticfuse / staticfuse

Monorepo for Static Fuse Gatsby Themes
32 stars 4 forks source link

menuName option isn't working as described #50

Closed nicolad closed 5 years ago

nicolad commented 5 years ago

In README it says The name of the WordPress menu you'd like to use or 0 if you don't want to render a menu. I've set menuName key to 0, but it still renders the menu.

image

here is the menu being rendered: https://kaizen.blog

justinwhall commented 5 years ago

Hey there! So you're looking for a way to have no menu at all? What we do is we look for a menu, if you have a WP menu set, we use that. If not, we render the default publisher menu: Home, blog, about, contact. You can see that logic here.

I suppose we should also have a check here if you have starterPages set to 0, then render no menu items. Does that help?

nicolad commented 5 years ago

Yes, it wouldn't make sense to default to publisher menu when there are no starter pages.

nicolad commented 5 years ago

Have created a PR for this: https://github.com/staticfuse/staticfuse/pull/52