search

statiolake / ddc-ale

ALE source for ddc.vim
14 stars 1 forks source link

Update to support new ddc apis #7

Closed amadeus closed 3 years ago

amadeus commented 3 years ago

Another day, another API change.

refresh_candidates was deprecated and deleted, which relegated this plugin to being completely broken. I've updated it to support the new callback api. I'd like to give it a day or two to test, just to ensure nothing subtle is broken, but yeah, it does simplify things a bunch.

Also updated things to support the latest deps, which meant moving some files around and all that.

amadeus commented 3 years ago

The reason you introduced refresh_candidate() was to speed up initial completion (provided by other sources) by returning empty result temporaly. Now what's the difference between this and my old implementation?

Yeah, not sure about this now, perhaps ddc works around it? Or perhaps there's some modifications we can make to support this faster response functionality, @Shougo thoughts?

Shougo commented 3 years ago

@amadeus @statiolake Please see it why I have changed the behavior.

https://github.com/Shougo/ddc.vim/pull/62

amadeus commented 3 years ago

Alright, I've been sitting on this now for a day or two, seems to be working just fine, and feedback should be fully addressed!