statiolake / proconio-rs

Apache License 2.0
126 stars 7 forks source link

Enable rust-analyzer to infer `Readable::Output` #18

Closed qryxip closed 3 years ago

qryxip commented 3 years ago

Before: before After: after

qryxip commented 3 years ago

We may release v0.3.7, as this change does not affect the actual behavior.

qryxip commented 3 years ago

The CI is

disabled because there hasn't been activity in this repository for at least 60 days.

On the forked one, Clippy jobs are failing for beta toolchains.

https://github.com/qryxip/proconio-rs/runs/2158233114?check_suite_focus=true

qryxip commented 3 years ago

20

statiolake commented 3 years ago

Confirmed in Visual Studio Code too:

Edit Looking closer, original image seems Visual Studio Code too. Sorry!

image

Seems OK to me. I'm not sure but we can expect CI is now good... Let's merge it.

Thank you for this great improvement! I'll backport this to v0.3 branch too.