stationer / SortTable

A pure JavaScript (no dependencies) solution to make HTML Tables sortable
MIT License
37 stars 12 forks source link

colNum is not increased when header has js-sort-none class #6

Closed adamnowocin closed 1 year ago

adamnowocin commented 4 years ago

https://github.com/stationer/SortTable/blob/54ec5d229037ce1b56d0a1f2ad6f778e33aa00b4/sort-table.js#L266

colNum is not increased when header has js-sort-none class and when you later sort the table it gets value from wrong column

tyleruebele commented 4 years ago

Thank you. That bug appears to have been added in https://github.com/stationer/SortTable/issues/5.

It should be easy to fix as https://github.com/stationer/SortTable/pull/7/files?diff=unified&w=1.

I didn't test this yet, so I didn't merge it yet, but it looks straightforward.

tyleruebele commented 1 year ago

merged