Optimizing Replace method in MemoryExtensions

[phil-scott-78]

I was taking a look at some of the perf and poked around here. With 4,000 files the little things are starting to add up. Did two main things

• Convert to a span outside of the loop. This is actually a pretty cheap call, but with this many NormalizedPath being created it gets called a ton
• Pull the span outside of the loop to compare once.

Took the number of times the call to the Span getter and the indexer were being called from 200 million times down to 5 million. This helps out a bit with the constructor knocking the total amount of time spent building those up on my machine from 18s down to 5.

Before

After

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[phil-scott-78]

Went to bed and thought to myself - "wait a second, those were all getters...I bet I had it on Debug mode like a moron."

Did a second test and sure enough, compiler takes care of those things for me. Disregard!