Custom _variables.less not applying certain variables

statiqdev / Statiq.Web

Statiq Web is a flexible static site generator written in .NET.

https://statiq.dev/web

Other

1.64k stars 236 forks source link

Custom _variables.less not applying certain variables #836

Open SilentSin opened 5 years ago

SilentSin commented 5 years ago

I have a custom _variables.less file in my input project which I had previously only used to change the @brand-primary color.
I just tried to change the @table-border-color, but it had no effect.
Copying the .table-bordered style from _tables.less exactly as is into override.less now allows it to apply my custom border color, but this doesn't seem like it should be necessary.

daveaglick commented 5 years ago

Very interesting - I would have expected your new table border value to take precedence just as the brand does. I’ve been using Bootstrap 4 more recently, so maybe I’m spacing on how Bootstrap 3 applies variables. I’ll take a closer look when porting the theme for vnext.