search

statiqdev / Statiq.Web

Statiq Web is a flexible static site generator written in .NET.
https://statiq.dev/web
Other
1.64k stars 234 forks source link

Support modifying Feed paths #970

Closed Turnerj closed 2 years ago

Turnerj commented 2 years ago

Fixes #960

Using FeedRss, FeedAtom and FeedRdf keys, you can specify true, false or a string path. Specifying true/false will behave as before. When you specify a path, this will be the destination path used for the feed itself.

Turnerj commented 2 years ago

FYI, the build errors seem to relate to your recent commit adding MediaTypes.Statiq but that isn't available in the NuGet version of Statiq.App. For myself, I saw the Statiq.Web.csproj file does support using a local Statiq.Framework but wasn't sure the way I was meant to enable it to do that locally (I just commented out those erroring lines and ran the new test and it passed).

daveaglick commented 2 years ago

Yeah, I still haven't figured out a good way to run PR build checks while Web has dependencies on in-flight changes in Framework. I should probably figure out how to download the Framework source and use it for testing, but that's a problem for another day :)

daveaglick commented 2 years ago

Looks great, thanks!

Turnerj commented 2 years ago

Yeah, I still haven't figured out a good way to run PR build checks while Web has dependencies on in-flight changes in Framework. I should probably figure out how to download the Framework source and use it for testing, but that's a problem for another day :)

I know that the checkout action in GitHub Actions can clone other repos but depending whether you build your release packages via it or not, you'll likely run into issues about whether it references your Statiq.Framework NuGet package correctly or not.

(Also, just in case you didn't see it with all the notifications you've gotten from me in the last few days, I've got 2 small PRs on Statiq.Framework you might want to look at when you have time 😊)