search

statiqdev / Statiq.Web

Statiq Web is a flexible static site generator written in .NET.
https://statiq.dev/web
Other
1.64k stars 234 forks source link

Fix validation if link contains non-ASCII characters #989

Closed theranger closed 1 year ago

theranger commented 2 years ago

Link validation fails if the link was generated from a file that contains non-ASCII characters. Although links themselves are created properly and are urlencoded, the validator misses decoding step.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

daveaglick commented 1 year ago

Sorry for the extremely late response here - I got swamped over the summer and am just now starting to dig out. It does look like a very similar change to this PR was already made along the way - there were a number of bug reports related to this behavior so I must have cleaned it up at some point. Thanks a ton for taking the time to run this down though - if nothing else your having solved it in the same way is a great validation of the fix!