statist7 / LMSgrowth2

MIT License
2 stars 2 forks source link

refactoring for preferences & persistence #24

Closed tamuri closed 5 years ago

tamuri commented 5 years ago
statist7 commented 5 years ago

Hi Asif,

Thanks for this. Do I need to install shinyjs or should it be there already?

I’ve taken quantreg out of the latest version of sitar, so it’s failing on MacOS won’t be problem going forward.

I’m on leave next week and will respond the following week.

Best wishes, Tim

tamuri commented 5 years ago

Yes, we need the shinyjs package. Update dependencies using packrat::restore() in the project.

statist7 commented 5 years ago

Hi Asif,

I’m doing something wrong…

I went to the Git tab in my LMSgrowth2 project in Rstudio, and pulled the select-reference branch. I then ran packrat::restore() with the results below. Can you advise?

Thanks, Tim

packrat::restore()

The following packages were not installed by packrat and will be ignored: _ shinyjs 1.0

If you would like to overwrite them, call restore again with overwrite.dirty = TRUE. Error: Unable to retrieve package records for the following packages:

tamuri commented 5 years ago

Hi Tim, That error is raised because the LMSgrowth2 package itself is installed in your R environment. You can get a clean packrat restore by removing it first:

remove.packages('LMSgrowth2')
packrat::restore()
statist7 commented 5 years ago

Hi Asif,

Thanks – that helps!

Now test_that is failing as the ref argument is missing from .measurement_to_scores. I’m not sure what default to give it so it picks up selected_ref.

Best wishes, Tim

tamuri commented 5 years ago

Thanks, Tim. Fixed!