add density tab

[statist7]

This adds a new tab to display the density function of a given LMS transformation

It would be good if the display updated as the slider moves - how do I do that?

[tamuri]

Doesn't seem as if there's any way to have the plot update whilst dragging; it only redraws when mouse button is released. I had a look at the javascript and there might well be a way to hack it...but no out-of-the-box solution, unfortunately.

[statist7]

I've pushed a commit that requires the shinyWidgets library. Please can this be added to packrat?

And is this something I could do myself?

[tamuri]

Hi Tim - you can do it yourself. Once you've installed the library in the LMSgrowth2 packrat environment, you can run the command packrat::snapshot(snapshot.sources = FALSE)

That will update the packrat/packrat.lock file, which you can then commit and push. It's probably a good idea to check the changes in the file to make sure it all is as you expect (hopefully will only add lines for the new library).

[statist7]

I’ve run packrat::snapshot(snapshot.sources = FALSE)but packrat.lock does not update. Running the snapshot also throws up errors about not retrieving package records for RcppArmadillo, progress, vctrs etc. In each case I install the package and rerun the snapshot, only for further errors to emerge. What is going on?

Also, progress seems to need rlang 0.4.0 rather than 0.3.4 – how do I update it? update.packages(‘rlang’) does nothing.

Thanks for your thoughts – I’ll get the hang of packrat eventually…

[tamuri]

Strange errors. Not sure what could be going on - did you install any packages other than shinyWidgets.

I just created a new environment from the master branch packrat, switched to your branch, ran install.packages('shinyWidgets') and then packrat::snapshot(snapshot.sources = FALSE). The following packages were added to the packrat lock file:

Adding these packages to packrat:
                 _      
    RColorBrewer   1.1-2
    colorspace     1.4-1
    labeling       0.3  
    munsell        0.5.0
    scales         1.0.0
    shinyWidgets   0.4.9
    viridisLite    0.3.0

I can update this here if you want to move on for now.

[statist7]

Thanks Asif. Yes please, do update them.

It’s frustrating not understanding what’s going on…

[tamuri]

I agree, these errors can be maddening. However, one of the benfits of using something like packrat to manage the R environment is that it you can reset by (i) ensuring you revert any changes to the packrat.lock file and then (ii) packrat::restore().

[statist7]

It's not clear, can I merge this PR without an approving review?

[tamuri]

You'll need one of us to approve before merging. Are you done with changes now?

[statist7]

Yes, I’m happpy with it. Thanks