search

statist7 / LMSgrowth2

MIT License
2 stars 2 forks source link

Some improvements to centile tab #38

Closed giordano closed 4 years ago

giordano commented 4 years ago

Implement changes requested by Tim at https://github.com/UCL/LMSgrowth2/pull/31#issuecomment-556136778.

For the time being here only the first two points are done, others will come at a later point.

giordano commented 4 years ago

Regarding the features requested at https://github.com/UCL/LMSgrowth2/pull/31#issuecomment-556136778 but not implemented here

  1. We need to rethink the role of the centile table now we have the plot available. Could the table display be toggled with a button, perhaps next to the sexes?

Asif will probably look into doing this with some Javascript

  1. Some of the plotly features don't seem to work, e.g. the download. Some may be because there are no points.

@statist7 I'm not sure I understand what's the problem here. I assume you're talking about the button to download the plot as a PNG. This gives you a plot with the same data that is shown before clicking on the button, so if you zoomed in a region where there are no datapoints you'll get a PNG file with no datapoints. This is how plotly works, I don't think we have much control over this. Is this what you're seeing?