search

statisticalbiotechnology / maracluster

Matthew The's implementation of MaRaCluster
Apache License 2.0
11 stars 3 forks source link

Index out of bounds (both MGF and mzML) #23

Closed kesinger closed 2 years ago

kesinger commented 2 years ago

I'm having the same problem as in https://github.com/statisticalbiotechnology/maracluster/issues/19 . I'm on version 1.01.1 (Apr 23 2020 13:12:07), which I downloaded from the Releases tab.

This happens on both MGF and mzML input. Original run was:

maracluster batch -b filelist

And consensus run was:

 maracluster consensus -l maracluster_output/MaRaCluster.clusters_p10.tsv -o maracluster_output/consensus.ms2

No output is produced. I have not yet tried building from source.

MatthewThe commented 2 years ago

Thanks for reporting this!

Would you be able to share some input files that produce this error?

kesinger commented 2 years ago

It actually happens with https://github.com/Luxxii 's example from https://github.com/statisticalbiotechnology/maracluster/issues/19 (once I edit the .tsv to account for different directory structures).

BUT I built from top-of-master and it worked! Would you be willing to cut a new release with changes since 1.01.1?

MatthewThe commented 2 years ago

Ah, yes absolutely. I somehow thought I had created a new release for this fix already..

MatthewThe commented 2 years ago

I just created a new release, let me know if you still run into issues.