search

statisticalbiotechnology / triqler

The triqler (TRansparent Identification-Quantification-linked Error Rates)'s source and example code
Apache License 2.0
19 stars 9 forks source link

Optimizations #16

Closed seantur closed 1 year ago

seantur commented 1 year ago

Hey @MatthewThe , thanks for the great work on this package!

We spent a little bit of time profiling Triqler and found a couple of cases where list comprehensions could be replaced with numpy methods for some quick gains. We also had a use case where we needed to up the CSV field size limit and thought it made sense to make it configurable.

As a note, the tests don't pass in my setup, but I do get the same results from the master branch to this one - I'm not sure if that's a difference in dependencies or python versions or something.

Happy to make any changes if needed!

MatthewThe commented 1 year ago

Thanks for the pull request! Nice that you managed to optimize the code.

The tests worked fine on my machine, so it's probably indeed just a (slightly) different environment.

I will create a release with the new changes.