search

statisticianinstilettos / recmetrics

A library of metrics for evaluating recommender systems
MIT License
568 stars 98 forks source link

Adds `mapk` implementation #50

Closed mrkaye97 closed 1 year ago

mrkaye97 commented 1 year ago

Closes https://github.com/statisticianinstilettos/recmetrics/issues/49

I do have some questions about the implementation though. I'll leave them as comments

mrkaye97 commented 1 year ago

Some additional questions / comments:

  1. Is there a reason why there's no CI process running the unit tests?
  2. I was having trouble restoring the dependencies in the lockfile using poetry. To get poetry install working I just manually nuked the pyproject file and the lockfile and completely reinitialized the project from scratch. It'd be great if someone could try to repro that issue, though. Here's the error:
(recmetrics-py3.9) (base) matt@Matt-Kayes-MBP recmetrics % poetry install
Installing dependencies from lock file

Unable to read the lock file (Cannot declare ('package', 'dependencies') twice (at line 1115, column 22)).