getrandbits() should save the leftovers to avoid extra calls to nextRandom(), and should check k

statlab / cryptorandom

Pseudorandom number generators based on cryptographic hash functions

https://statlab.github.io/cryptorandom/

BSD 2-Clause "Simplified" License

3 stars 10 forks source link

Closed pbstark closed 6 years ago

pbstark commented 6 years ago

the current code will fail if k > HASHLEN.
many calls to nextRandom() could be saved in repeated calls to getrandbits when k<<256 by having a class variable to cache "leftover" bits rather than discarding (HASHLEN-k). Track the number of bits remaining, and call nextRandom() when the cache of bits is exhausted.