statnet / ergm.ego

Fit, Simulate and Diagnose Exponential-Family Random Graph Models to Egocentrically Sampled Network Data https://statnet.org
Other
14 stars 4 forks source link

Should we suppress the ergm estimation message for the degreedist.egodata function? #12

Closed martinamorris closed 6 years ago

martinamorris commented 6 years ago

currently, the degreedist.egodata function prints out the ergm model fitting message when is specified.

this seems unnecessary -- the info is not useful -- and it could lead to confusion among users, since they have not explicitly made a call to ergm.

martinamorris commented 6 years ago

Pavel, did you close this because you don't agree, or b/c you made the change?

mbojan commented 6 years ago

It's fixed @martinamorris

martinamorris commented 6 years ago

It's fixed @martinamorris

k, thx. usually there's a link included to the commit

krivit commented 6 years ago

k, thx. usually there's a link included to the commit

I had forgotten to mention the issue it in the commit, so I had linked to the commit in the closing message instead.

martinamorris commented 6 years ago

I had forgotten to mention the issue it in the commit, so I had linked to the commit in the closing message instead.

dang, did i just miss that? i could swear there wasn't a commit # reference in the closing message when i looked earlier. sorry if i just missed it...

krivit commented 6 years ago

It's this one:

krivit closed this in 4ef757b 11 days ago

The string of hex characters is the commit ID that fixed it.