search

statnet / ergm.ego

Fit, Simulate and Diagnose Exponential-Family Random Graph Models to Egocentrically Sampled Network Data https://statnet.org
Other
14 stars 4 forks source link

ego terms update #32

Closed chad-klumb closed 5 years ago

chad-klumb commented 5 years ago

fixes statnet/ergm.ego#26

fixes statnet/ergm.ego#27

notes:

there is no term versioning in ergm.ego

mean.age is not tested as I don't see an ergm analogue

krivit commented 5 years ago

mean.age is in tergm. Don't worry about it.

krivit commented 5 years ago

@chad-klumb , Travis CI seems to be malfunctioning. Can you please confirm that you've run R CMD check on your branch and that nothing is broken? Thanks in advance.

chad-klumb commented 5 years ago

I did run R CMD check and everything was fine.

I just noticed we still need deprecation messages, though. Also, I thought of a better implementation for nodemix's new levels argument.

I can get both of those in tomorrow.

Is there a preferred message writer at this point?

krivit commented 5 years ago

Thanks! Message writer?

chad-klumb commented 5 years ago

I meant the function called to write the messages

I used message in the current PR but that could easily be changed to something else

krivit commented 5 years ago

No, message is probably the best. We should probably implement the same template mechanism as we have for InitErgmTerm, but that's in the future.