statnet / ergm.ego

Fit, Simulate and Diagnose Exponential-Family Random Graph Models to Egocentrically Sampled Network Data https://statnet.org
Other
14 stars 4 forks source link

Possible incompatibility of `ergm.ego` with testthat 3.0. #49

Closed krivit closed 3 years ago

krivit commented 3 years ago
Dear Pavel N. Krivitsky,

This is an automated email to let you know that:

* A new version of testthat is ready to go to CRAN. testthat is
currently at version 2.99.0.9000 and will become 3.0.0 upon release.

* ergm.ego uses testthat and has problems with the new version.

* We plan to submit testthat to CRAN on Oct 12.

Please let me know if there's anything I can do to help :)

I need your help to keep ergm.ego and testthat working together
smoothly. In the next one week, can you please:

1. Read about the changes to testthat at
https://github.com/r-lib/testthat/blob/master/NEWS.md#testthat-development-version.
This page includes a list of breaking changes, the reasoning behind
them, and to how to update your code.

2. Carefully inspect the failing checks listed at the bottom of this email.

3. For each failing check, either update your package, or tell me
that I have a bug. If you have made changes to your package, please
submit an update to CRAN before Oct 12.

If you have discovered a bug in testthat, please file an issue
(ideally with a small reprex that illustrates the problem) at
https://github.com/r-lib/testthat/issues. If you're not sure whether
or not you've found a bug, please file an issue at
https://github.com/r-lib/testthat/issues for discussion. Breaking
changes that are not listed qualify as bugs.

Please respond to this message if you have any questions.

Thanks,

Hadley Wickham

== CHECK RESULTS ========================================

* checking tests ... ERROR
...
Running ‘EgoStat.tests.R’
Running ‘boot_jack.R’
Running ‘table_ppop.R’
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
── Warning (test-statmismatch.R:10:1): (code run outside of
`test_that()`) ─────
`context()` was deprecated in the 3rd edition.

── ERROR (test-statmismatch.R:15:1): (code run outside of
`test_that()`) ───────
Error: could not find function "egodata"

══ testthat results
═══════════════════════════════════════════════════════════
Warning (test-degreedist.R:10:1): (code run outside of `test_that()`)
ERROR (test-degreedist.R:21:1): (code run outside of `test_that()`)
Warning (test-statmismatch.R:10:1): (code run outside of `test_that()`)
ERROR (test-statmismatch.R:15:1): (code run outside of `test_that()`)

[ FAIL 2 | WARN 2 | SKIP 0 | PASS 0 ]
Error: Test failures
Execution halted
mbojan commented 3 years ago

I'm not sure why the Error: could not find function "egodata" error. All passes on my machine. Let's close if Travis passes.

mbojan commented 3 years ago

Travis fails on 1 machine because of infrastructure problems, passes on other 2. I think we can close this now and perhaps reopen if testthat 3.0 is released and some more problems pop up.