I210 as network numeric - Githubissues

statnet / ergm

Fit, Simulate and Diagnose Exponential-Family Models for Networks

Other

96 stars 37 forks source link

I210 as network numeric #504

Closed AryaKarami closed 1 year ago

krivit commented 1 year ago

While we are at it, can you please also add the following?

Produce an informative error for each of the following invalid or unsupported inputs:

[ ] Both directed=TRUE and bipartite!=FALSE, and both are passed (use missing() to check).
[x] loops=TRUE.
[x] multiple=TRUE.
[x] hyper=TRUE.
[x] numedges is given and is not an integer.
[x] numedges>ndyads.
[x] density is not between 0 and 1 (inclusive).

Also,

[x] If bipartite!=FALSE and directed==TRUE but directed is not passed explicitly (i.e., missing(directed)==TRUE, set directed=FALSE and issue a warning() informing the user and stating that this behaviour may change in the future.

Lastly, implement testthat tests in a file tests/testthat/test-as.network.numeric.R (using networks small enough that they don't take much time).

[x] The above error and warning behaviours (using expect_error() and expect_warning()).
[x] Correct number of edges for directed, undirected, and bipartite networks if numedges is passed, for reasonable numedges.
[x] Correct number of edges for complete graphs (maximum possible numedges) or density==1.

krivit commented 1 year ago

@AryaKarami , can you please catch up your fork's master and merge the changes into this branch?