statnet / ergm

Fit, Simulate and Diagnose Exponential-Family Models for Networks
Other
98 stars 37 forks source link

'ergm' and everything LinkingTo ergm should work with STRICT_R_HEADERS=1. #579

Closed krivit closed 2 months ago

krivit commented 2 months ago

Quoth CRAN:

Specifically, please see the *Strict* additional issue.

Compilation fails with _R_USE_STRICT_R_HEADERS_=true, which defines
STRICT_R_HEADERS to 1 which removes

- the legacy definition of PI (use POSIX's M_PI, available in R fer ever).
- the RS.h declarations for Calloc, Realloc, Free (use R_ forms i
  available since R 3.4.0).

The aim is to clean the namespace: in particular having a definition
for Free has conflicted with some packages' C++ code.

It is planned that STRICT_R_HEADERS=1 will become the default for 4.5.0,
for which it would be good if all CRAN packages, and in particular the
ones with strong reverse dependencies, compile/install ok with the new
default.

Your package is among the ones with strong reverse dependencies which
need updating.  We would thus really appreciate if you could provide a
new version of your package as soon as possible which checks ok with
STRICT_R_HEADERS=1.

You can verify that your package checks ok with STRICT_R_HEADERS=1 via R
CMD check --as-cran using a current version of R-devel.

This should be mostly search-and-replace for Calloc(), Free(), and Realloc(), but there might be other instances.