CRAN takedown notice about writing files outside of tmp

[skyebend]

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_ndtv.html.

Please correct before 2021-10-21 to safely retain your package on CRAN.

The check problems on the Debian systems are caused by attempts to write to the user library to which all packages get installed before checking (and which now is remounted read-only for checking).

Having package code which is run as part of the checks and attempts to write to the user library violates the CRAN Policy's

Packages should not write in the user’s home filespace (including clipboards), nor anywhere else on the file system apart from the R session’s temporary directory (or during installation in the location pointed to by TMPDIR: and such usage should be cleaned up).

[skyebend]

   Error in `install.mdsj(mdsj.dir)`: Unable to install MDSJ because the package path /home/hornik/tmp/R.check/r-release-gcc/Work/build/Packages/ndtv/java/does not appear to have write permissions
     Backtrace:
     1. ndtv:::check.mdsj(ask = FALSE)
     2. ndtv:::install.mdsj(mdsj.dir)

context: when ndtv (optionally) installs the MDSJ package, it doesn't do it in a temp dir because that wouldn't make sense. I thought I'd previously dealt with this by having it not test the installation capabilities on CRAN .. perhaps something changed

[skyebend]

I did fix this previously by not running theses tests on CRAN, but looks like there may be a problem with the skip_on_cran() with the new testthat package release? https://github.com/r-lib/testthat/issues/1470

Hoping to resolve quickly as ndtv has been taken down from CRAN

[skyebend]

have not heard back from testthat, attempting re-release with these tests commented, in CRAN release queue (as a new package, so could take 10 days)

[skyebend]

ndtv is back on CRAN! testthat recommending changes in directory structure to fix problems, will consider for next release