statnet / ndtv

ndtv: Network Dynamic Temporal Visualizations in R
https://cran.r-project.org/web/packages/ndtv/index.html
49 stars 5 forks source link

Takedown warning from cran about missing tergm package #52

Closed skyebend closed 1 year ago

skyebend commented 1 year ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_ndtv.html.

Please correct before 2022-11-21 to safely retain your package on CRAN.

Packages in Suggests should be used conditionally: see 'Writing R Extensions'. This needs to be corrected even if the missing package(s) become available. It can be tested by checking with _R_CHECK_DEPENDSONLY=true.

The CRAN Team

krivit commented 1 year ago

Someone who shall go unnamed changed a part of ergm API that broke tergm, so I am releasing them in rapid succession. This should fix itself shortly.

skyebend commented 1 year ago

corrections made, pushed to CRAN ... fingers crossed (skye, before closing this issue, don't forget to tag release)

krivit commented 1 year ago

Eh? I got tergm back on CRAN, so I didn't think any changes were needed.

skyebend commented 1 year ago

there was some examples code in the vignettes that I guess was not appropriately tolerant of missing Suggests packages (i.e. package shouldn't have broken w/o tergm anyway)

But seems all good now!

Thanks, on its way to CRAN. Best, Uwe Ligges