statnet / ndtv

ndtv: Network Dynamic Temporal Visualizations in R
https://cran.r-project.org/web/packages/ndtv/index.html
46 stars 5 forks source link

CRAN-requested updates to documentation #57

Open skyebend opened 2 days ago

skyebend commented 2 days ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_ndtv.html.

Please correct before 2024-07-02 to safely retain your package on CRAN.

Best, -k

Check Details

Version: 0.13.3
Check: Rd files
Result: NOTE
  checkRd: (-1) render.d3movie.Rd:104: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:105: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:106: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:107: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:108: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:109: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:110: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:111: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:112: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:113: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:114: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:115: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:116: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:117: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:118: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:119: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:126: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:127: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:136: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:137: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:138: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:139: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:141: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:142: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:143: Lost braces in \itemize; meant \describe ?
  checkRd: (-1) render.d3movie.Rd:144: Lost braces in \itemize; meant \describe ?
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/ndtv-00check.html), [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/ndtv-00check.html), [r-devel-linux-x86_64-fedora-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/ndtv-00check.html), [r-devel-linux-x86_64-fedora-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/ndtv-00check.html), [r-patched-linux-x86_64](https://www.r-project.org/nosvn/R.check/r-patched-linux-x86_64/ndtv-00check.html), [r-release-linux-x86_64](https://www.r-project.org/nosvn/R.check/r-release-linux-x86_64/ndtv-00check.html), [r-release-macos-arm64](https://www.r-project.org/nosvn/R.check/r-release-macos-arm64/ndtv-00check.html), [r-release-macos-x86_64](https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/ndtv-00check.html)

Version: 0.13.3
Check: re-building of vignette outputs
Result: WARN
  Error(s) in re-building vignettes:
...
mbojan commented 2 days ago

How nice of them to give us time for fixing that... ;)

niedz., 30 cze 2024, 14:32 użytkownik Skye Bender-deMoll < @.***> napisał:

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_ndtv.html https://cran.r-project.org/web/checks/check_results_ndtv.html.

Please correct before 2024-07-02 to safely retain your package on CRAN.

Best, -k

Check Details

Version: 0.13.3 Check: Rd files Result: NOTE checkRd: (-1) render.d3movie.Rd:104: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:105: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:106: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:107: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:108: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:109: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:110: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:111: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:112: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:113: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:114: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:115: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:116: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:117: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:118: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:119: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:126: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:127: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:136: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:137: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:138: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:139: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:141: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:142: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:143: Lost braces in \itemize; meant \describe ? checkRd: (-1) render.d3movie.Rd:144: Lost braces in \itemize; meant \describe ? Flavors: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-patched-linux-x86_64, r-release-linux-x86_64, r-release-macos-arm64, r-release-macos-x86_64

Version: 0.13.3 Check: re-building of vignette outputs Result: WARN Error(s) in re-building vignettes: ...

— Reply to this email directly, view it on GitHub https://github.com/statnet/ndtv/issues/57, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE3NHSM2GNPZA7HWJSGCZTZKACF7AVCNFSM6AAAAABKEDVMCWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DEMRVGY4DCNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

skyebend commented 2 days ago

How nice of them to give us time for fixing that... ;)

This part is my fault, they sent the email a while ago and I'm finally sitting down to fix it this weekend.

It seems like there has also been another tightening of definitions on requirements around "Suggests" definitions I'm trying to sort through that

skyebend commented 1 day ago

submitted to CRAN, fingers crossed. Skye, don't forget to merge https://github.com/statnet/ndtv/pull/59 if successful

skyebend commented 1 day ago

this is always so frustrating: submission rejected with a new list of issues, not raised by any previous tests:

* checking Rd cross-references ... NOTE
Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
  filmstrip.Rd: plot.network, networkDynamic
  msm.sim.Rd: networkDynamic
  network.layout.animate.Rd: network.layout.kamadakawai
  proximity.timeline.Rd: plot.network, network.collapse, isoMDS,
    sammon, get.networks
  render.animation.Rd: plot.network, animation, ani.replay, saveVideo,
    ani.options, ani.record, plot.network.default
  render.d3movie.Rd: networkDynamic, plot.network.default, plot.network
  timeline.Rd: plot.network, plotArgs.network
  transmissionTimeline.Rd: network, plot.network
Please provide package anchors for all Rd \link{} targets not in the
package itself and the base packages.
skyebend commented 11 hours ago

Almost there! (after 6 submission rounds over 2 days) package ndtv_0.13.4.tar.gz has been auto-processed and is pending a manual inspection. A CRAN team member will typically respond to you within the next 5 working days. For technical reasons you may receive a second copy of this message when a team member triggers a new check.

Kurt was very patient, and offered this helpful suggestion for reproducing errors that were showing up in cran checks but not other systems:

Currently this needs a reasonably current r-devel and 

  _R_CHECK_XREFS_NOTE_MISSING_PACKAGE_ANCHORS_=true

in the system environment.  Should get added to --as-cran and be used on
win-builder soon, all work in progress ...