statnet / network

Classes for Relational Data
Other
15 stars 8 forks source link

I32 mixingmatrix #50

Closed mbojan closed 3 years ago

mbojan commented 3 years ago

Simpler object returned by mixiningmatrix(), closes #32:

mbojan commented 3 years ago

CI passes but with notes and warnings. I will still fix via this PR:

── R CMD check results ───────────────────────────────── network 1.17.0-585 ────
Duration: 1m 5.5s

❯ checking Rd \usage sections ... WARNING
  Undocumented arguments in documentation object 'network.indicators'
    ‘...’

  Functions with \usage entries need to have the appropriate \alias
  entries, and all their arguments documented.
  The \usage entries must correspond to syntactically valid R code.
  See chapter ‘Writing R documentation files’ in the ‘Writing R
  Extensions’ manual.

❯ checking files in ‘vignettes’ ... WARNING
  Files in the 'vignettes' directory but no files in 'inst/doc':
    ‘networkVignette.Rnw’, ‘networkVignette.pdf’

❯ checking package vignettes in ‘inst/doc’ ... WARNING
  dir.exists(dir) is not TRUE
  Package vignette without corresponding single PDF/HTML:
     ‘networkVignette.Rnw’

❯ checking CRAN incoming feasibility ... NOTE
  Maintainer: ‘Carter T. Butts <buttsc@uci.edu>’

  Unknown, possibly mis-spelled, fields in DESCRIPTION:
    ‘Remotes’

  The Date field is over a month old.

❯ checking R code for possible problems ... NOTE
  print.mixingmatrix: no visible global function definition for
    ‘addmargins’
  Undefined global functions or variables:
    addmargins
  Consider adding
    importFrom("stats", "addmargins")
  to your NAMESPACE file.

0 errors ✔ | 3 warnings ✖ | 2 notes ✖
mbojan commented 3 years ago

Ready, apart from the vignette part. This hasn't been touched since 2015. Seems like the logic of keeping compiled vignettes within the package changed (?)

krivit commented 3 years ago

No comments from Carter, so I'll go ahead and merge.