search

statnet / networkDynamic

Dynamic Extensions for Network Objects
10 stars 1 forks source link

Takedown notice for test failure when Pajek website briefly offline #10

Closed skyebend closed 10 months ago

skyebend commented 3 years ago

On 13/09/2021 08:36, Prof Brian Ripley wrote:

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_networkDynamic.html.

Please correct before 2021-10-05 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

For the record, the failure was

--- re-building ‘networkDynamic.Rnw’ using Sweave Loading required package: network

‘network’ 1.17.1 (2021-06-12), part of the Statnet Project

‘networkDynamic’ 0.11.0 (2021-06-12), part of the Statnet Project

trying URL 'http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip' Warning in download.file("http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip", : URL 'http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip': status was 'Couldn't connect to server'

Error: processing vignette 'networkDynamic.Rnw' failed with diagnostics: chunk 47 (label = download_paj) Error in download.file("http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip", : cannot open URL 'http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip'

CarterButts commented 3 years ago

Yes, I got a similar note about network for this issue.  We should probably just supply the files internally and not link to an external resource.....

-Carter

On 9/13/21 8:54 PM, Skye Bender-deMoll wrote:

On 13/09/2021 08:36, Prof Brian Ripley wrote:

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_networkDynamic.html
<https://cran.r-project.org/web/checks/check_results_networkDynamic.html>.

Please correct before 2021-10-05 to safely retain your package on
CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with
an informative message
if the resource is not available or has changed (and not give a
check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

For the record, the failure was

--- re-building ‘networkDynamic.Rnw’ using Sweave Loading required package: network

‘network’ 1.17.1 (2021-06-12), part of the Statnet Project

‘networkDynamic’ 0.11.0 (2021-06-12), part of the Statnet Project

trying URL 'http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip' Warning in download.file("http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip", : URL 'http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip': status was 'Couldn't connect to server'

Error: processing vignette 'networkDynamic.Rnw' failed with diagnostics: chunk 47 (label = download_paj) Error in download.file("http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip", : cannot open URL 'http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip http://vlado.fmf.uni-lj.si/pub/networks/data/esna/Sampson.zip'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/statnet/networkDynamic/issues/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJM3GDT2ZA2YWPVPIGMWITUB3BODANCNFSM5D7GOIRA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

skyebend commented 3 years ago

On 9/13/21 9:04 PM, CarterButts wrote:

Yes, I got a similar note about network for this issue. If network uses Sampson also, maybe we should add it there? Or was it for a different file?

We should

probably just supply the files internally and not link to an external resource.....

I imagine that the spurious errors are painful waste of time for CRAN maintainers ... but this is an example in the vignette where we demo how to download external files! I'll see if it is easier to just rework the example

CarterButts commented 3 years ago

Hmm, yes, that is rather an issue.  I note that the initial form letter does suggest some possibilities for graceful failure, so that would provide another alternative....

-Carter

On 9/13/21 9:18 PM, Skye Bender-deMoll wrote:

On 9/13/21 9:04 PM, CarterButts wrote:

Yes, I got a similar note about network for this issue.
If network uses Sampson also, maybe we should add it there? Or was
it for a different file?

We should

probably just supply the files internally and not link to an external
resource.....

I imagine that the spurious errors are painful waste of time for CRAN maintainers ... but this is an example in the vignette where we demo how to download external files! I'll see if it is easier to just rework the example

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/statnet/networkDynamic/issues/10#issuecomment-918786775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJM3GH4NUWOM27K3RNM6YDUB3EJDANCNFSM5D7GOIRA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

martinamorris commented 3 years ago

We could host the files in the repo, but not include them in the package, so that would be an external web scrape

mbojan commented 3 years ago

Alternatively in the long term perhaps let's just add it to https://github.com/statnet/statnet.data and Import it?

martinamorris commented 10 months ago

FYI, we have been asked to host the Sampson data several times. I think we should do it.

On Sat, Dec 2, 2023 at 11:24 PM Skye Bender-deMoll @.***> wrote:

Closed #10 https://urldefense.com/v3/__https://github.com/statnet/networkDynamic/issues/10__;!!K-Hz7m0Vt54!kain73Jh0pkXPv4lh-a9dgCjgaFxsrhV64Nm2shDV8QwZXoPtObIQMEv9CEVIdMh5I0yp5F0U53B4QkImViAXW8$ as completed.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/statnet/networkDynamic/issues/10*event-11130872996__;Iw!!K-Hz7m0Vt54!kain73Jh0pkXPv4lh-a9dgCjgaFxsrhV64Nm2shDV8QwZXoPtObIQMEv9CEVIdMh5I0yp5F0U53B4QkIebwkBYA$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB6QTYTVANGGNLRCCUCGIN3YHQSKBAVCNFSM5D7GOIRKU5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGEYTGMBYG4ZDSOJW__;!!K-Hz7m0Vt54!kain73Jh0pkXPv4lh-a9dgCjgaFxsrhV64Nm2shDV8QwZXoPtObIQMEv9CEVIdMh5I0yp5F0U53B4QkIgnIbAoU$ . You are receiving this because you commented.Message ID: @.***>