statnet / networkDynamic

Dynamic Extensions for Network Objects
10 stars 1 forks source link

import networkLite and define as.networkDynamic.networkLite #16

Closed chad-klumb closed 1 year ago

chad-klumb commented 2 years ago

This PR imports the (new) networkLite package and defines as.networkDynamic.networkLite (which is needed to support tergm applications of networkLites). This will permit e.g. ergm to import networkLite without depending on networkDynamic. Version number and ChangeLog have been updated.

skyebend commented 2 years ago

As Chad notes, networkLite needs to be on CRAN first, and probably remotes lite removed before merging to master

next CRAN push could be organized to first push networkLite, then push statnet packages in the usual order, then push the EpiModel package after tergm goes up.

skyebend commented 1 year ago

sorry I haven't been following up on this. Looks like I need to do a release to CRAN this weekend to quiet some other issues. Are the reverse depends ready for this if we try to include it?

skyebend commented 1 year ago

just noticed this in the CRAN docs, wondering if the correct relationship with networkLite is 'enhances'?

Finally, the ‘Enhances’ field lists packages “enhanced” by the package at hand, e.g., by providing methods for classes from these packages, or ways to handle objects from these packages (so several packages have ‘Enhances: chron’ because they can handle datetime objects from chron even though they prefer R’s native datetime functions). Version requirements can be specified, but are currently not used. Such packages cannot be required to check the package: any tests which use them must be conditional on the presence of the package. (If your tests use e.g. a dataset from another package it should be in ‘Suggests’ and not ‘Enhances’.)

krivit commented 1 year ago

Yes, I believe Enhances is the right relationship.

chad-klumb commented 1 year ago

networkLite is not on CRAN so this will have to wait for a later release

some people dislike Enhances, e.g.

  • Enhances: packages listed here are “enhanced” by your package. Typically, this means you provide methods for classes defined in another package (a sort of reverse Suggests). But it’s hard to define what that means, so we don’t recommend using Enhances.

https://r-pkgs.org/dependencies.html

smjenness commented 1 year ago

HI @skyebend!

networkLite is now on CRAN: https://cran.r-project.org/package=networkLite

Would you please merge this PR and push networkDynamic up to CRAN.

Once complete, we can continue updating EpiModel and related packages.

Thanks! Sam

smjenness commented 1 year ago

Hi @skyebend : it looks like you merged this PR into master last week. Could you push this latest version up to CRAN? We are waiting on updating and publishing EpiModel for this newest version of networkDynamic to be on CRAN. Thanks!

skyebend commented 1 year ago

@smjenness Yes, I merged, but was having trouble getting revdep tests to run locally (seemed more like a failure of revdep than statnet package problems) I'll try some more today, @chad-klumb were you able to run this previously, do we feel pretty confident that reverse-depending 3rd party packages will be ok?

chad-klumb commented 1 year ago

revdepcheck did not indicate any issues

skyebend commented 1 year ago

submitted (sorry for delay). leaving this open to remember to push branch if it is sucessful

skyebend commented 1 year ago

'package networkDynamic_0.11.3.tar.gz is on its way to CRAN.'

smjenness commented 1 year ago

Excellent, thanks @skyebend!