skyebend
commented
10 months ago Closed skyebend closed 9 months ago
skyebend
commented
10 months ago skyebend
commented
10 months ago I will also attempt to update my maintainer email to non-csde (tho that may take more than one release?) and attempt to integrate the recent updates
skyebend
commented
10 months ago I'm reluctant to install R-devel locally to reproduce the error (unless anybody has an easy solution for switching between R versions locally?) So I'll try to take a first pass to get the github actions Michael added working to see if I can reproduce there
mbojan
commented
10 months ago I have r-devel installed on my ubuntu and will check it.
skyebend
commented
9 months ago I'm working through most of the (trivial) doc updates on https://github.com/statnet/networkDynamic/tree/doc-fix to prep a release
But just noticing that there is a C compiler warning surfaced as they continue to tighten optional flags:
wtedgetree.c:628:23: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘double’ [-Wformat=]I don't really know C, @CarterButts or @krivit any quick suggestions to update the diagnostic print function, looks like the line is Rprintf("\t.weight=%d\n",edges[e].weight);? is it just changing to %f instead of %d ?
krivit
commented
9 months ago I'm working through most of the (trivial) doc updates on https://github.com/statnet/networkDynamic/tree/doc-fix to prep a release
But just noticing that there is a C compiler warning surfaced as they continue to tighten optional flags:
wtedgetree.c:628:23: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘double’ [-Wformat=]I don't really know C, @CarterButts or @krivit any quick suggestions to update the diagnostic print function, looks like the line is
Rprintf("\t.weight=%d\n",edges[e].weight);? is it just changing to%finstead of%d?
Yes, that's exactly right. ergm got dinged for the same thing, and it's getting an update shortly. (I don't know how much the two edgetree implementations had diverged, however.)
mbojan
commented
9 months ago @skyebend ,
The CI tests on doc-fix look in the green now, but in fact all the warnings are there in the log (the default GH action settings report red only in case of errors which is not conservative enough for CRAN). See the log at https://github.com/statnet/networkDynamic/actions/runs/7140780417/job/19446748344#step:13:1
I pulled the repo, checked-out doc-fix branch, built and checked with current r-devel (updated and recompiled yesterday). I'm getting:
RD CMD build networkDynamic
* checking for file ‘networkDynamic/DESCRIPTION’ ... OK
* preparing ‘networkDynamic’:
* checking DESCRIPTION meta-information ... OK
* cleaning src
Warning: /tmp/RtmpRK3CYk/Rbuild1e38a7d03bc60/networkDynamic/man/networkDynamic-package.Rd:63: unexpected section header '\keyword'
Warning: /tmp/RtmpRK3CYk/Rbuild1e38a7d03bc60/networkDynamic/man/networkDynamic-package.Rd:64: unexpected section header '\seealso'
Warning: /tmp/RtmpRK3CYk/Rbuild1e38a7d03bc60/networkDynamic/man/networkDynamic-package.Rd:70: unexpected END_OF_INPUT '
'
* installing the package to build vignettes
* creating vignettes ... OK
Warning: ‘inst/doc’ file
‘networkDynamic.pdf’
ignored as vignettes have been rebuilt.
Run R CMD build with --no-build-vignettes to prevent rebuilding.
* cleaning src
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
* looking to see if a ‘data/datalist’ file should be added
* building ‘networkDynamic_0.11.4.tar.gz’RD CMD check networkDynamic_0.11.3.tar.gz
* using log directory ‘/home/mbojan/R/src/networkDynamic.Rcheck’
* using R Under development (unstable) (2023-12-04 r85659)
* using platform: x86_64-pc-linux-gnu
* R was compiled by
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
GNU Fortran (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
* running under: Ubuntu 22.04.3 LTS
* using session charset: UTF-8
* checking for file ‘networkDynamic/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘networkDynamic’ version ‘0.11.3’
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘networkDynamic’ can be installed ... WARNING
Found the following significant warnings:
wtedgetree.c:628:23: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘double’ [-Wformat=]
See ‘/home/mbojan/R/src/networkDynamic.Rcheck/00install.out’ for details.
* used C compiler: ‘gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0’
* checking installed package size ... OK
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking whether startup messages can be suppressed ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... NOTE
Argument items with no description in Rd file 'print.networkDynamic.Rd':
‘\dots’
* checking for unstated dependencies in examples ... OK
* checking contents of ‘data’ directory ... OK
* checking data for non-ASCII characters ... OK
* checking data for ASCII and uncompressed saves ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking compiled code ... OK
* checking sizes of PDF files under ‘inst/doc’ ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
Running ‘activate_tests.R’
Running ‘age.at_tests.R’
Running ‘classTests.R’
Running ‘converter_tests.R’
Running ‘get_tests.R’
Running ‘import_tests.R’
Running ‘network_tests.R’
Running ‘pid_tests.R’
Running ‘query_tests.R’
Running ‘reconcile.activityTests.R’
Running ‘tea_tests.R’
Running ‘utils_tests.R’
Running ‘when_tests.R’
OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ...
‘networkDynamic.Rnw’... OK
OK
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... OK
* DONE
Status: 1 WARNING, 1 NOTE
See
‘/home/mbojan/R/src/networkDynamic.Rcheck/00check.log’
for details.I think most issues fixed now (@mbojan is it building cleanly for you?), but still need to try to resolve
Apparent methods for exported generics not registered:
as.networkDynamic.siena
See section 'Registering S3 methods' in the 'Writing R Extensions'
manual.flag on win-devel
mbojan
commented
9 months ago I think most issues fixed now (@mbojan is it building cleanly for you?), but still need to try to resolve
yep
skyebend
commented
9 months ago Submitted to CRAN!
skyebend
commented
9 months ago Dear maintainer, thanks, package networkDynamic_0.11.4.tar.gz is on its way to CRAN. Best regards, CRAN teams' auto-check service Package check result: OK No changes to worse in reverse depends.