statnet / networkDynamic

Dynamic Extensions for Network Objects
10 stars 1 forks source link

cran warning: S3 generic/method consistency 'get.vertex.attribute.active' 'list.vertex.attributes.active' #5

Closed skyebend closed 4 years ago

skyebend commented 4 years ago

seems like refactor of S3 generics for network did break something for networkDynamic

https://cran.r-project.org/web/checks/check_results_networkDynamic.html

Check Details

Version: 0.10.0
Check: S3 generic/method consistency
Result: WARN
    get.vertex.attribute:
     function(x, ...)
    get.vertex.attribute.active:
     function(x, prefix, onset, terminus, length, at, rule, na.omit,
     null.na, active.default, dynamic.only, require.active,
     return.tea, unlist)

    list.vertex.attributes:
     function(x, ...)
    list.vertex.attributes.active:
     function(x, onset, terminus, length, at, na.omit, rule, v,
     require.active, active.default, dynamic.only)

    See section 'Generic functions and methods' in the 'Writing R
    Extensions' manual.

    Found the following apparent S3 methods exported but not registered:
     get.vertex.attribute.active list.vertex.attributes.active
    See section 'Registering S3 methods' in the 'Writing R Extensions'
    manual. 
chad-klumb commented 4 years ago

IIRC this was the point of PR #2

skyebend commented 4 years ago

Ah! thanks @chad-klumb ! I was confused, since I remembered that you had worked through this, forgot we were waiting to merge until network on cran

skyebend commented 4 years ago

released to CRAN