search

statnet / networkDynamic

Dynamic Extensions for Network Objects
10 stars 1 forks source link

updates for new network generics #7

Closed chad-klumb closed 4 years ago

chad-klumb commented 4 years ago

apparently package cross-reference requirements are changing with r-devel, which is what 0e7decac60ede79b16b34eba4c2a7b8a6ba7d6dd addressed

chad-klumb commented 4 years ago

To my surprise R CMD check did not demand that I add el as an argument to get.edge.attribute.active despite it now appearing in the generic. (Apparently before vs. after the dots makes a difference in this regard.) Nonetheless, "Writing R Extensions" is pretty unequivocal,

A method must have all the arguments of the generic, including … if the generic does.

so I've added it anyway. If el is not missing in a call to get.edge.attribute.active, an error is now produced.

I also added a documentation entry for get.edge.attribute.active, which apparently didn't have one before.

chad-klumb commented 4 years ago

updated to depend on master branch of network

skyebend commented 4 years ago

@chad-klumb this is great! I'm looking over PR, reviewing docs etc this week. Do you know if reverse depends of networkDynamic have been tested with these changes?

skyebend commented 4 years ago

I checked out revdeps for tsna and ndtv, seem great! I did find a broken link in the vignette (unrelated to these changes). I think we should merge this PR and then I can do a couple of tweaks like that

chad-klumb commented 4 years ago

I have not run reverse dependencies of networkDynamic, but let me know if you need me to.

chad-klumb commented 4 years ago

Any objection to merging this now? We are getting various packages ready for CRAN release and it's convenient if we can test all the updates together by using master versions of everything.