search

statnet / statnetWeb

A graphical user interface for network modeling with the 'statnet' software
GNU General Public License v3.0
29 stars 17 forks source link

CRAN error #70

Closed martinamorris closed 5 years ago

martinamorris commented 5 years ago

CRAN folks found the following error and have asked us to fix it:

Found the following \keyword or \concept entries
which likely give several index terms:
  File 'run_sW.Rd':
    \keyword{GUI,}

The offending line is here

Any idea what they're asking for?

skhan890 commented 5 years ago

We need to delete the comma , separating the two keywords, according to Roxygen2 documentation (https://cran.r-project.org/web/packages/roxygen2/vignettes/rd.html). I'll make the change and push it up.

skhan890 commented 5 years ago

@martinamorris Okay - this is now fixed! https://github.com/statnet/statnetWeb/blob/master/R/run_sw.R#L7

You can push up to CRAN again.

skhan890 commented 5 years ago

I also ran the devtools::check() function on the fixed statnetWeb repo. This gave no errors, so hopefully it should go through CRAN smoothly!

image

martinamorris commented 5 years ago

Yup, it passed that check before I submitted yesterday. It's not uncommon for this check to be fine, but CRAN still reject for other reasons.

But I've fixed the two things they noted (with your help, thx) and have resubmitted.

martinamorris commented 5 years ago

Should leave this open until CRAN approves the submission

martinamorris commented 5 years ago

This was finally fixed by running roxygen to update the .Rd files