statnett / vue-plotly

A vue wrapper for plotly.js chart library
MIT License
118 stars 28 forks source link

Changing plotly newplot to plotly react. #11

Closed Mynamewasused closed 5 years ago

Mynamewasused commented 6 years ago

New Plot is expensive and discards event handlers, react is a better option.

Bob-Thomas commented 6 years ago

indeed like mentioned in #10

manthey commented 5 years ago

This also would fix issues #12 and #16.

harryjubb commented 5 years ago

@statnett @gwdekker @wendelborg any update on this?

mokkabonna commented 5 years ago

This PR broke the tests, the referenced commit also fixes tests. Data need to be immutable or datarevision need to be set. I chose the latter approach in watch handler for data.