statonlab / hardwoods_site

Hardwoods Genomics bugs, data loading, and general issues
GNU General Public License v3.0
2 stars 1 forks source link

Fields settings are all wrong #589

Closed almasaeed2010 closed 4 years ago

almasaeed2010 commented 4 years ago

Bug description

All of our custom fields define chado tables and columns to auto handle data insertion, retrieving and deleting. However, most of our fields don't provide a widget and should not be defining a this information. This could cause fields to insert or delete data from the database unintentionally. It could also slow the website down since Tripal will try to look for un-needed data in the database. Most of the queries I found try to pull data from the analysis and organism tables.

Additional info

To fix this, we'll need to go through every module we use and make sure the module_name.fields.inc file defines the appropriate instance settings. In particular, we need to look at the 'chado_column', 'base_table' and 'chado_table' keys in HOOK_bundle_instances_info().

@jwest60 @noahcaldwell7 let's get together and discuss this since it's a big change and we'll need to work together to get all the fields fixed.

almasaeed2010 commented 4 years ago

List of modules to fix:

almasaeed2010 commented 4 years ago

Great work @jwest60 and @noahcaldwell7

All fixed and successfully deployed 👍