statonlab / hardwoods_site

Hardwoods Genomics bugs, data loading, and general issues
GNU General Public License v3.0
2 stars 1 forks source link

hwd site theme issue for tripal galaxy webform fields #77

Closed MingChen0919 closed 6 years ago

MingChen0919 commented 6 years ago

Some webform fields are not themed correctly in our HWG site theme.
Specifically, some field titles are not bolded. field values are not nested within the corresponding field titles. See the screenshot below. The one on the right is the default, and it's correct.

screen shot 2018-01-10 at 1 14 09 pm
MingChen0919 commented 6 years ago

Since this is a HWG theme issue, I need Abdullah's help on this:)

almasaeed2010 commented 6 years ago

If at all possible, could you provide the code snippet that creates this form?

Thanks!

MingChen0919 commented 6 years ago

I'll need to ask Connor, I forgot this yesterday. Remind me if I forget again.

MingChen0919 commented 6 years ago

hi @almasaeed2010, those incorrectly themed texts/titles/labels belong to the type of fixed_value. I think here is the code that renders fixed_value elements. https://github.com/tripal/tripal_galaxy/blob/7.x-1.x/includes/components/tripal_galaxy.fixed_value.inc#L80-L87.

almasaeed2010 commented 6 years ago

I can't find the rendered html to be able to style it. In which workflow and step does this issue arise?

MingChen0919 commented 6 years ago

it arises at all workflows as long the webform component is fixed_value. It is a custom form element defined by tripal galaxy module to render fixed values from workflows. see the WGCNA workflow Step 2 as an example: http://160.36.205.61:8095/content/wgcna-analysis.

Here is the component type defined in the webform data: https://github.com/statonlab/dibbs/blob/master/annotated-tripal-galaxy-workflows/wgcna.json#L266

please let me know if you need more info, or maybe discuss in person?

almasaeed2010 commented 6 years ago

Fixed in both live and dev. @MingChen0919 could you please verify the issue is fixed and close this if so?

MingChen0919 commented 6 years ago

confirmed. thanks!