search

statrs-dev / statrs

Statistical computation library for Rust
https://docs.rs/statrs/latest/statrs/
MIT License
546 stars 78 forks source link

Update nalgebra to 0.32 #187

Closed kalev closed 2 months ago

Heeten commented 5 months ago

Any change of getting this merged? @kalev just curious what you're doing in the meantime as I need this and am wondering if I should use my own fork for the time being.

kalev commented 5 months ago

I ended up patching it downstream in Fedora in the mean time, https://src.fedoraproject.org/rpms/rust-statrs/c/3b588181bafc5bb693f334a2c0bde0fd910e4c47?branch=rawhide

YeungOnion commented 4 months ago

Hi, I'm a new co-maintainer! I have no opposition to this, nothing acts up as I increase version dependence incrementally by minor release and none of nalgebra's changelog seems to an issue for what we have here.

However, as @henryjac (our other maintainer) and I just accepted the role, we haven't figured out how we'll go about maintaining this, and I think this should be part of decisions about a next release. What do you think @henryjac?

henryjac commented 4 months ago

I think we should add some of the other existing PRs like this together with some more pressing issues. Issue 195 is probably something we should look into as it concerns copyright issues.

Overall I think getting out a release soon would be a good first milestone and show that the crate is still being maintained.

YeungOnion commented 4 months ago

@henryjac, sounds like it'll be useful to make a gh milestone for 0.16 release and add things to it so we can discuss on those issues. I'll do that and add this issue and the NIST one for now. Let me know if you have a different suggestion.

henryjac commented 4 months ago

Sounds good! I'll see what other reasonable PRs that could be added.

Also, I think the release would be 0.17. It's a bit confusing with the numbering with it being both 0.15 and 0.16 at some places, but the latest release on crates.io is 0.16.

Another thing I have thought about is having a semi-linear git history. I feel it keeps the history cleaner but still shows work done at merges. I enabled a check that let's the branch be automatically be rebased onto master which we would do before merging in this case.