Closed YeungOnion closed 1 month ago
I removed tests that didn't require that a, b < ∞
AND a<b
but I noticed there were tests that specifically tested such behavior, most notably things like
The blame shows @boxtown writing some of those tests 8 years ago and some from @dcraven 3 years ago. Don't suppose you recall why you chose that before, do you? I'd like to know more about what I'm considering removing.
EDIT: Mention @dcraven's additions, despite not being able to find his gh account
More discussion is needed on what's expected behavior for such degenerate cases, #102 will host future discussion, for now I'll exclude this degenerate case.
In looking at lints (#216, has some of the discussion there) adjacently found that Uniform would allow infinite support. I don't know enough to say if this is well defined mathematically, but a few implications I thought of:
sample
will fail while usingrand
's UniformSamplercdf
andsf
have odd end behaviors for the unbounded end, is F(x = INF) = 1 if X ~ Uni(a, INF)? Equals INF isn't good math, but is valid value for floatsThere may be others, but this PR would disallow construction of such a distribution,
sf
was implemented to have behavior for infinite support, butcdf
was not. If someone can declare how it should work, then we can reallow it and implement all the behavior for it.