Closed FreezyLemon closed 2 months ago
Attention: Patch coverage is 9.52381%
with 38 lines
in your changes missing coverage. Please review.
Project coverage is 93.70%. Comparing base (
d0a5b04
) to head (5ae4760
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks again for what you've put in with the last 24 hours. It looks good, just gotta handle the merge.
This should be good to go. I resolved the merge conflicts manually, and the CI failure is just codecov
Needed to rebase again after the other PRs were merged.
coverage CI looks stuck. I'm messing around with it on poorly named pr #279
Now, I will merge the correct thing. Whoops.
After #270, making
rand
optional means that it's possible to use a very stripped-down version of the crate:Like the
nalgebra
feature,rand
is enabled by default. This added modularity might make #165 easier, too.This requires a breaking change: Removing the
rand::distribution::Distribution<T>
supertrait fromstatrs::distribution::Distribution<T>
and::DiscreteDistribution<T>
. Semantically, it means that thestatrs
distributions are not required to berand
distributions and are not logical extensions of them. Practically, it just means that new distributions don't necessarily have to implement therand
Distribution trait (all current distributions still do implement it with the feature enabled).I would argue that the distribution traits still make sense without rand/RNG. This also allows using most of the
statistics
module without needing to compilerand
and all that entails.