search

statrs-dev / statrs

Statistical computation library for Rust
https://docs.rs/statrs/latest/statrs/
MIT License
599 stars 84 forks source link

run coverage on stable rust #279

Closed YeungOnion closed 2 months ago

YeungOnion commented 2 months ago

at the moment, the coverage job for 275 doesn't finish compiling, hangs while reporting Compiling criterion v0.5.1.

Wanting to exclude issues from rustc, using using updated nightly and updated stable compiled the tests on my machine.

Tested here with stable, and the compile passes, next text is doing it on the branch where the issue was seen.

YeungOnion commented 2 months ago

stable passes compile for the rand feature as well, trying nightly.

YeungOnion commented 2 months ago

reproduced as expected, as this is identical to #275 and of course, revert to master and check nightly on ci, not wanting to miss that just because it worked on my machine.

YeungOnion commented 2 months ago

unsure which nightly dtolnay/rust-toolchain uses, but next test is the one that worked locally, nightly-2024-08-29

YeungOnion commented 2 months ago

quoted from #268,

Looks like CI is stuck due to rust-lang/rust#130056

Not sure there's much to do about it at the moment. It's just nightly being affected

I'm going to approve this because it compiles on my machine, unless you think I should hold off, I hope within the week the coverage reports will be good again.

FreezyLemon commented 2 months ago

Seems fine.