search

stats4sd / Sampling-Decision-Assistant

GNU General Public License v3.0
0 stars 0 forks source link

Refactor all subscriptions to call unsubscribe #182

Open chrismclarke opened 5 years ago

chrismclarke commented 5 years ago

A number of subscriptions don't have unsubscribe methods. Need to check whether these will be handled automatically (i.e. linked to async pipe in related component), or should be handled manually either through explicit unsubscribe call or chained 'takeUntil / first' etc.

Comments on best practice here: https://medium.com/@benlesh/rxjs-dont-unsubscribe-6753ed4fda87

Have currently refactored tree-table and stage 2

chrismclarke commented 5 years ago

have worked on a few more, to be systematic should check for all .subscribe methods, see if could be handled with async pipes and if not manage with unsubscribe or takeUntil