search

stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Add transition to principle assessment modals #101

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

Minor PR - adds a subtle transition to the PrincipleAssessmentModal component. Previously, when you clicked "save and next" during the principle assessment it was not immediately obvious that the content had changed. This adds a small fade-out and in to make it easier to see that you have moved to the next principle in the list.

Also added a max-width for styling on wider screens.

dave-mills commented 1 year ago

Before:

https://github.com/stats4sd/aec_portfolio/assets/5711101/8eea52a9-b679-4d9f-b0f4-77c875d531e5

After:

https://github.com/stats4sd/aec_portfolio/assets/5711101/fe92dda0-5166-4a14-969d-6df49fc6ca61

dan-tang-ssd commented 1 year ago

I pulled latest code and run "npm run build", refreshed in browser. Not quite sure why it does not work on browsers (Firefox, Safari, Edge) in my local env.

According to the video, it is a nice feature. I will approve this PR now, as there is no business logic changed.

dan-tang-ssd commented 1 year ago

It works now after running below commands:

composer install

npm install