Additional criteria view

stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System

GNU General Public License v3.0

0 stars 0 forks source link

Additional criteria view #105

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

This PR generalises the PrincipleAssessment vue components to also work with the Additional Criteria Assessment.

There are some things pending, so I'm calling this a draft PR. @dan-tang-ssd can you take a look at these?

[x] The "complete" status is not being correctly pulled on initial load, which means the completed criteria do not turn green / do not have the score displayed. (The rest of the data seems to be pulled, e.g. the rating, rating_comment and custom_score_tags are all correctly retrieved and displayed when you click into the Modal).
[x] The finalisation process is not working propertly. It is still hard-linked to the principle-assessment finalisation endpoint, so will need adapting to a different end point that sets the "additional_status" on the assessment.

dan-tang-ssd commented 1 year ago

I executed below commands, the Vue component not showed when assessing additional criteria...

==========

git checkout dev

git pull

==========

git checkout additional-criteria-view

git pull

npm run dev

==========

composer install

npm install

npm run dev

dan-tang-ssd commented 1 year ago

Screen shots:

Assess Red Flags and Assess Principles are working fine

Access Additional Criteria, the Vue component not showed...

dave-mills commented 1 year ago

I've updated this PR so the vue component should now render, and made a few additional tweaks to fix some issues with the save / finalise workflow.

dan-tang-ssd commented 1 year ago

Um.... for additional criteria assessment, should we have a different title and description?

dan-tang-ssd commented 1 year ago

As I have only one additional assessment criteria in my local env, I would like to add some more for testing.

When I add / edit additional assessment criteria, below error occurred...

dave-mills commented 1 year ago

When I add / edit additional assessment criteria, below error occurred...

Fixed in the latest commit. The issue was with my change in relationship name. (I made the AdditionalCriteria->scoreTags() name match the AssessmentPrinciple class so we could use the same name in the Vue component. I'd found all the main references, but PHPStorm didn't find the one hidden in the string name of the CRUD field).

dan-tang-ssd commented 1 year ago

Thank you Dave.

The Add / Edit additional criteria links work well now. I have added a new additioanl criteria successfully.

Just one minor issue about "Discard Changes" button. It updates the value in front end. When I refresh browser, the correct value showed. (The same issue happens for principle assessment...)

Screen shots FYI:

Assess criteria, score is 1 now

Showing scroe as 1

Change score from 1 to 2, click Discard Changes button

Score is showed as 2 in front end

Refresh browser, score is showed as 1

dave-mills commented 1 year ago

Just one minor issue about "Discard Changes" button. It updates the value in front end.

I believe this issue is fixed in #134, so I wouldn't worry about it here.