stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Fix initiative sorting #115

Closed dan-tang-ssd closed 1 year ago

dan-tang-ssd commented 1 year ago

This PR is submitted for fix issue #93.

It contains below changes:

  1. Revise codes for filtering records, make sorting works when no filter applied
  2. Add sortBy, sortDir in computed() function, make sorting works when any filter applied
  3. Complete resetFilters() function, make Reset button works
  4. Sort initiatives records by name in ascending order, which match the default value of sortBy and sortDir
  5. Special handling for Reset button when there is a portfolio specified in GET parameter
dan-tang-ssd commented 1 year ago

Screen shots

Enter initiatives page to show all initiatives of my institution image

By default, initiatives records are sorted by name in ascending order now image

Change sorting from ascending order to descending order, initiatives records sorted accordingly image

Change sortBy from "Name" to "Date added", initiatives records sorted accordingly image

Apply any filters (1 filter to 4 filters), initiatives records filtered accordingly image

Change sortBy or sortDir when filters applied, initiatives records sorted accordingly image

Remove any filters, initiatives records filtered accordingly image

Click "Reset" button to reset all filters, all initiatives records showed image

dan-tang-ssd commented 1 year ago

We can enter initiatives page in another way, by showing initiatives of a specific portfolio image

The specified portfolio is in GET parameter of URL, portfolio filter is filled in automatically. image

We can apply any filters as usual image

When we click "Reset" button, portfolio filter remains the selected portfolio. It only shows initiative of the specified portfolio image

image

dan-tang-ssd commented 1 year ago

Considering this is 4:42 PM already. To minimise possible risk and provide user support, I will merge this PR into dev branch on 2023-07-06 (Thu) morning.

dan-tang-ssd commented 1 year ago

Live env deployment is completed. Performed testing with positive testing result.

I will close issue #93.