stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

add 'next assessment stage' buttons to red flags and principles #145

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

This PR addresses a request to include a link to continue the next stage of the assessment within the current assessment:

On the Red Flags page

This is done by overwriting the default save options within Backpack. Instead, the buttons are included directly in the redline.blade.php template.

CleanShot 2023-07-17 at 17 25 01

Principle Assessment

Similar to the red flags, a new option is added to take the user directly to the additional criteria assessment page. This option only appears when the organisation has additional criteria active. It is enabled when the assessment is marked as finalised and disabled when not.

CleanShot 2023-07-17 at 17 30 03

dan-tang-ssd commented 1 year ago

Pulled latest code and performed testing in local env.

Create a new initiative, "Save" button caption is not correct...

image

dan-tang-ssd commented 1 year ago

Created a new initiative, assess red flags image

Click "Save and Start Principle Assessment" button image

It does not divert to assess principles. It goes back to initiatives page... image

dan-tang-ssd commented 1 year ago

Assess principles image

Click "Finalise and begin Additional Assessment" button image

It diverts to assess additioanl assessment, success image

dave-mills commented 1 year ago

Create a new initiative, "Save" button caption is not correct...

Fixed by reverting to the previous save button trait setup.

It does not divert to assess principles. It goes back to initiatives page...

Fixed by harmonising how both "save and..." buttons work. Now both use the same startAssessment() method.

Thanks :)

dan-tang-ssd commented 1 year ago

Thank you Dave. It works well now. Now we have a very smooth process from creating new initiative to finalise additional assessments in one go.

P.S. I have also disabled additional assessment criteria, then created a new initiative and assessed them smoothly.

Screen shots:

Create new initiative, Save button caption is correct now image

New initiative created, assess red flags image

Click "Save and Start Principle Assessment" button image

It goes to assess principle directly now image

Click "Finalise and begin Additional Assessment" button image

It goes to assess additional assessment criteria now image

Finalise additional assessment image

It goes back to initiative page, the newly created initiative has been fully assessed image