stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Extra institution + portfolio details #155

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

fixes #146.

This PR adds the required extra information to portfolios and organisations, as per the technical specification.

Updates

The tech specs were not fully clear on whether institutions and portfolios should be linkable to continents/regions/countries. I chose to not do this, but am open to this being a requested feature if it is deemed to be vital.

This PR also adds InstitutionType as a new data model, linked to institutions.

dave-mills commented 1 year ago

NOTE: on merge, we should run the InstitutionTypeSeeder on the live site to setup the list of institution types.

dan-tang-ssd commented 1 year ago

Institution Settings Fill in optional information, click "Save" button

image

Um... optional information not saved... image

Checked database, optioanl information not saved into database image

dan-tang-ssd commented 1 year ago

NOTE: on merge, we should run the InstitutionTypeSeeder on the live site to setup the list of institution types.

I have executed InitiativeCategorySeeder and InstitutionTypeSeeder for initial data loading in local env.

dan-tang-ssd commented 1 year ago

Create a new portfolio, fill in a very big budget, save, success

image

image

Edit the newly created portfolio, change to a even bigger budget, overflow. Um... should we check budget for the maximum value?

image

image

dan-tang-ssd commented 1 year ago

Create a new initiative, failed to save It keeps compainting my selected Geographic reach is invalid. I have tried all three options with same result...

image

image

image

dave-mills commented 1 year ago

Create a new initiative, failed to save It keeps compainting my selected Geographic reach is invalid. I have tried all three options with same result...

Mia culpa. I realised that the enum name/value was the wrong-way round, so I swapped it over in the form, but not in the validation :)

(portfolios) ... Um... should we check budget for the maximum value?

Yes, absolutely. Can you add this?

Um... optional information not saved...

Should be fixed in the latest commit.

dan-tang-ssd commented 1 year ago

Performed testing with positive result:

  1. New initiative can be saved
  2. Settings > Optional Information can be saved

Added validation to check for maximum value of portfolio budget, i.e. 18446744073709551615.

Screen shots:

Error message showed if portfolio budget > 18446744073709551615 image

The maximum portfolio budget is 18446744073709551615 image

image

dave-mills commented 1 year ago

@dan-tang-ssd thanks :)

dan-tang-ssd commented 1 year ago

Checked live database, we have initiative_categories record but we do not have institution_types records. I have exported records from my local db and imported them into live db.