Closed dave-mills closed 1 year ago
NOTE: on merge, we should run the InstitutionTypeSeeder on the live site to setup the list of institution types.
Institution Settings Fill in optional information, click "Save" button
Um... optional information not saved...
Checked database, optioanl information not saved into database
NOTE: on merge, we should run the InstitutionTypeSeeder on the live site to setup the list of institution types.
I have executed InitiativeCategorySeeder and InstitutionTypeSeeder for initial data loading in local env.
Create a new portfolio, fill in a very big budget, save, success
Edit the newly created portfolio, change to a even bigger budget, overflow. Um... should we check budget for the maximum value?
Create a new initiative, failed to save It keeps compainting my selected Geographic reach is invalid. I have tried all three options with same result...
Create a new initiative, failed to save It keeps compainting my selected Geographic reach is invalid. I have tried all three options with same result...
Mia culpa. I realised that the enum name/value was the wrong-way round, so I swapped it over in the form, but not in the validation :)
(portfolios) ... Um... should we check budget for the maximum value?
Yes, absolutely. Can you add this?
Um... optional information not saved...
Should be fixed in the latest commit.
Performed testing with positive result:
Added validation to check for maximum value of portfolio budget, i.e. 18446744073709551615.
Screen shots:
Error message showed if portfolio budget > 18446744073709551615
The maximum portfolio budget is 18446744073709551615
@dan-tang-ssd thanks :)
Checked live database, we have initiative_categories record but we do not have institution_types records. I have exported records from my local db and imported them into live db.
fixes #146.
This PR adds the required extra information to portfolios and organisations, as per the technical specification.
Updates
The database + seeders / factories are updated with the new fields
The portfolio table view now includes budget and geographic reach
Creating / editing portfolios via the CRUD panel controller has the extra fields:
Editing institution details is now via a Vue component, and includes the extra relevant fields.
Users without the "edit own institution" permission will see the fields as disabled.
The tech specs were not fully clear on whether institutions and portfolios should be linkable to continents/regions/countries. I chose to not do this, but am open to this being a requested feature if it is deemed to be vital.
This PR also adds InstitutionType as a new data model, linked to institutions.