search

stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

On the My Institution page, store the user's tab in Session for later #187

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

This PR fixes #162, by updating the Session cache storage with the user's current tab.

Previously, when returning to the My Institution page, the app would always reset to the Portfolios tab unless you specifically included a # in the url. This was particularly confusing when returning from any Additional criteria page, but more generally it's a nicer experience if the user goes back to the same place they left when returning to the page.

This PR adds to the page's JS to retrieve the stored tab ONLY if there is no # in the url (to allow the user or custom links to overwrite it). It also sends an ajax request when the user changes tabs to update the sesson storage on the server.

dan-tang-ssd commented 1 year ago

It works well, we have better UX now.

I made a little change to remove unnecessary character "J" next to "Change Institution" in top bar menu.

image

dave-mills commented 1 year ago

@dan-tang-ssd - nice, thanks!

dan-tang-ssd commented 1 year ago

Deployment in staging env is completed, performed testing with positive result.