stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Add visuals to represent NA principles #195

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

This PR addresses an issue highlighted by Emile, where there is no visual indication of principles that were marked as NA.

Currently,

Carlos suggested an improvement for the dashboard in the attached - adding a thin grey bar over the top of the main block colours for each principle to show the % of initiatives that marked the item as NA. This PR adds those bars, along with a description below the graphic.

The PR also updates the spider chart on the initiative show page to grey out the items marked as NA.

Suggestion for summary of initiatives.pptx

This PR doesn't address the 3rd slide, that includes suggested updates to the text / way of explaining the total rating for individual initiatives. We'll include that in a broader 'documentation / guides' PR.

dan-tang-ssd commented 1 year ago

I got latest code and performed testing in my local env.

I created a new portfolio and created a new initiative for testing. I finished assessing red flags, principles and additional criteria.

The principles marked as NA are showed in grey color, NA principles are listed for easy reference.

  1. Initiative > Show Information
  2. Initiative > Show Information > Generate PDF

image

image

dan-tang-ssd commented 1 year ago

In dashboard, I choose my newly created profolio. There is only one initiative in this portfolio. I have fully assessed red flags, principles and additional criteria. But "Fully assessed" is 0... Um... how do we consider an initiative as "Fully assessed"...?

The Total Budget and AE-focused Budget do not show amount... All migration files are executed in my local env. Including the recent one for projects.exchange_rate. Will it be related to column "budett_org"?

image

dan-tang-ssd commented 1 year ago

Dashboard > Summary of Red Flags, it is correct.

image

dan-tang-ssd commented 1 year ago

Dashboard > Summary of Principles

Nice to have below new feature:

  1. New note added for NA
  2. New tiny horizontal bar added to show percentage of principle assessment marked with NA

image

dan-tang-ssd commented 1 year ago

Dashboard > Summary of Principles

I realised that when mouse over a principle segment (GREEN / YELLOW / RED), a popup will show the percentage. The same feature also applies to the grey tiny bar, which is nice.

As the bar is quite tiny, it may be not easy to exactly move the mouse over it.... Maybe we will need to add instructions to mention this, probably in the upcoming small question mark ? inline help.

image

image

dan-tang-ssd commented 1 year ago

As discussed, I added a bug fix to exclude soft-deleted projects in dashboard stored procedure. Performed testing in my local env, confirmed that soft-deleted projects are excluded in dashboard.

dan-tang-ssd commented 1 year ago

In dashboard, I choose my newly created profolio. There is only one initiative in this portfolio. I have fully assessed red flags, principles and additional criteria. But "Fully assessed" is 0... Um... how do we consider an initiative as "Fully assessed"...?

The Total Budget and AE-focused Budget do not show amount... All migration files are executed in my local env. Including the recent one for projects.exchange_rate. Will it be related to column "budett_org"?

image

The dashboard budget not showed issue has been resolved in PR #199. The fully assessed also show correct value.

I think it is good to merge now.