Closed dave-mills closed 1 year ago
Pulled latest code, executed migration file, performed testing in local env.
Most testings are performed with positve result, just the last testing with question about the condition to show or hide principle summary.
It shows budget in two currencies when initiative currency is not same as institution currency. Score and rating looks good and clear.
It shows budget in one currency when initiative currency is same as institution currency.
In the generated PDF file, initiative basic info, spider chart, score and rating are always in page 1.
Principle summary is always in page 2.
For initiative not yet start red flag assessment, principle summary is not showed.
For initiative finished all assessments, then assess red flags and failed one red flag, principle summary is still showed. Question: Should we also check red flag status to determine whether to show principle summary or not?
Question: Should we also check red flag status to determine whether to show principle summary or not?
Good idea. I've just added that check in.
On the rendering error on other branches, I suggest we merge this one in, then merge dev branch into the other branches and it should be fine. It'll be a caching thing where the blade component is looking for the class added in this PR, (it's odd that once you've added a class, it always looks for it. Some caching thing that I don't understand, I assume).
PR to fix #197:
Also added a minor fix so that the blade help-text-link can now also act as a popover.