search

stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Review initiative sorting #211

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

Fixes #190.

Minor PR to set the correct default initiative sort settings when there is nothing in the Session storage. Previously the sorting and sort direction were set to 0, which meant there was no selected sort-by and the sort direction didn't work until you hit reset.

Also updated the project factory so the created_at for generated projects is randomised. I used this to check the created_at sort, which works correctly 👍.

dan-tang-ssd commented 1 year ago

I pulled latest code, got below error when perform testing...

image

dave-mills commented 1 year ago

I pulled latest code, got below error when perform testing...

Ah, I found this to be annoying too. Try php artisan view:clear, or merge in the dev branch once the review-init-review branch is merged.

dan-tang-ssd commented 1 year ago

Command "php artisan view:clear" works fine. The fix also works fine. I think it is good to merge now.