stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Fix Principle Rating Issue in Dashboard #221

Closed dan-tang-ssd closed 1 year ago

dan-tang-ssd commented 1 year ago

I found a bug in dashboard when I am doing testing in my local Linux env.

For a newly created portfolio with a newly created project, I assess red flag and principles with score 1.9 or 2.0. In dashboard, the principle summary for this portfolio not showing rating properly.

I suspect there may be something different about stored proc / function deployment in database in docker image.... P.S. I manually deployed stored proc / function in TablePlus due to permission issue before...

I did same testing in local Windows env, but it works properly. Principle summary can be showed correctly.

Suddenly I recall that dashboard_rating.max_rating for GREEN record needs to change to a value > 2.0, e.g. 2.01. This is to include principles scored 2.0. I update it in TablePlus then principle rating works properly in dashboard.

This PR contains a minor change with comments in Seeder file only.


Screen shots:

image

image

image