stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

always order institution types by admin-set ordering #237

Closed dave-mills closed 1 year ago

dave-mills commented 1 year ago

When "reordering" institution types on the admin panel (/admin/institution-type), the order set in re-ordering was not reflected in how they are displayed throughout the site.

This PR fixes that issue by adding an orderBy global scope.

It does the same for InitiativeCateogry.

dave-mills commented 1 year ago

@dan-tang-ssd - I'd like to publish this into the same main-branch PR I just created.

dan-tang-ssd commented 1 year ago

Hi Dave, I cannot see the difference on Organisation CRUD list view. Would you share which page I should perform testing?

Many Thanks.

dave-mills commented 1 year ago

Before, the "reorder" operation on Institution Type and Initiative Category would change the ordering of the list on their CRUD panels, but not anywhere else in the platform.

This means:

Now, those dropdown lists reflect the ordering chosen on those CRUD panels.

dan-tang-ssd commented 1 year ago

It works well, I think it is good to merge.