search

stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

fix for odd telecope-y bug? #240

Closed dave-mills closed 10 months ago

dave-mills commented 10 months ago

The stack-trace on this one was odd. It looks like the system was trying to json_serialise an empty assessment? So there was no project (because there was no data yet), but it was still trying to calculate the variables defined in $appends.

I have no idea why, but making the project optional with ? works. Now, if there is ever not a project set, the additional_score attribute will return null.

dave-mills commented 10 months ago

Note - I called it a telescope-y bug because of the stack-trace, where it all seems to start from a json_encode() call in the extractDataFromView() function in one of the telescope Watcher classes...

CleanShot 2023-11-15 at 12 29 59

dan-tang-ssd commented 10 months ago

Now it works fine. Thank you Dave. I think it is now ready to merge.